Mark Lord wrote (ao):
> Andrew Morton wrote:
> > Sander <sander@xxxxxxxxxxx> wrote:
> ..
> >> [ 86.569852] ata5: dev 0 cfg 49:2f00 82:7c6b 83:7f09 84:4063 85:7c69
> 86:3e01 87:4063 88:007f
> >> [ 86.569856] ata5: dev 0 ATA-7, max UDMA/133, 586114704 sectors: LBA48
> >> [ 86.570840] BUG: warning at
> drivers/scsi/libata-core.c:3884/__ata_qc_complete()
> >> [ 86.570902]
> >> [ 86.570903] Call Trace: <IRQ> <ffffffff80401694>{__ata_qc_complete+98}
> >> [ 86.571046] <ffffffff8040939e>{mv_interrupt+626}
> <ffffffff8023bf2c>{handle_IRQ_event+41}
> >> [ 86.571208] <ffffffff8023bffa>{__do_IRQ+155}
> <ffffffff8020c13b>{do_IRQ+59}
> >> [ 86.571365] <ffffffff80209d64>{ret_from_intr+0} <EOI>
> <ffffffff804eccd2>{__reacquire_kernel_lock+39}
> >> [ 86.571552] <ffffffff804eb9bd>{thread_return+166}
> <ffffffff804ebfe5>{schedule_timeout+138}
> >> [ 86.571713] <ffffffff8022a66c>{process_timeout+0}
> <ffffffff804eaeaf>{wait_for_completion_timeout+137}
> >> [ 86.571878] <ffffffff8021cc6f>{default_wake_function+0}
> <ffffffff80407402>{ata_exec_command+36}
> >> [ 86.572042] <ffffffff804038b8>{ata_exec_internal+266}
> <ffffffff80404473>{ata_set_mode+667}
> >> [ 86.575479] <ffffffff8023c4d1>{request_irq+130}
> <ffffffff804049f4>{ata_device_add+1163}
> >> [ 86.575639] <ffffffff80409a41>{mv_init_one+1547}
> <ffffffff8036c8b2>{pci_device_probe+221}
> >> [ 86.575799] <ffffffff803b999d>{driver_probe_device+82}
> <ffffffff803b9a52>{__driver_attach+0}
> >> [ 86.575959] <ffffffff803b9aa8>{__driver_attach+86}
> <ffffffff803b8f5a>{bus_for_each_dev+67}
> >> [ 86.576121] <ffffffff803b925a>{bus_add_driver+116}
> <ffffffff8036c918>{pci_bus_match+0}
> >> [ 86.576279] <ffffffff8036c418>{__pci_register_driver+85}
> <ffffffff8020720c>{init+455}
> >> [ 86.576438] <ffffffff8020a6b6>{child_rip+8}
> <ffffffff80207045>{init+0}
> >> [ 86.576582] <ffffffff8020a6ae>{child_rip+0}
> >
> > This is:
> >
> > void __ata_qc_complete(struct ata_queued_cmd *qc)
> > {
> > WARN_ON(qc == NULL); /* ata_qc_from_tag _might_ return NULL */
> > WARN_ON(!(qc->flags & ATA_QCFLAG_ACTIVE));
> >
> > complaining that ATA_QCFLAG_ACTIVE is not set.
>
> I am also working on stability for sata_mv now, and here is a patch
> that *may* fix the above error.
I'm sorry to say it doesn't fix the above output. Because it is
line-wrapped, I'll paste again for your convenience:
[ 83.489431] BUG: warning at drivers/scsi/sata_mv.c:1896/__msleep()
[ 83.489478]
[ 83.489479] Call Trace: <IRQ> <ffffffff8040ad0b>{__mv_phy_reset+242}
[ 83.489624] <ffffffff8040a1f7>{mv_channel_reset+133} <ffffffff8040b363>{mv_interrupt+556}
[ 83.489786] <ffffffff8023c120>{handle_IRQ_event+41} <ffffffff8023c1ee>{__do_IRQ+155}
[ 83.489947] <ffffffff8020c13b>{do_IRQ+59} <ffffffff8020834c>{default_idle+0}
[ 83.490108] <ffffffff80209d64>{ret_from_intr+0} <EOI> <ffffffff804ed947>{thread_return+0}
[ 83.490290] <ffffffff80208379>{default_idle+45} <ffffffff80208406>{cpu_idle+98}
[ 83.490446] <ffffffff807c8018>{start_secondary+1224}
[ 87.443699] ata5: dev 0 cfg 49:2f00 82:7c6b 83:7f09 84:4063 85:7c69 86:3e01 87:4063 88:007f
[ 87.443703] ata5: dev 0 ATA-7, max UDMA/133, 586114704 sectors: LBA48
[ 87.444684] BUG: warning at drivers/scsi/libata-core.c:3884/__ata_qc_complete()
[ 87.444748]
[ 87.444748] Call Trace: <IRQ> <ffffffff80403698>{__ata_qc_complete+98}
[ 87.444894] <ffffffff8040b3a0>{mv_interrupt+617} <ffffffff8023c120>{handle_IRQ_event+41}
[ 87.445054] <ffffffff8023c1ee>{__do_IRQ+155} <ffffffff8020c13b>{do_IRQ+59}
[ 87.445209] <ffffffff80209d64>{ret_from_intr+0} <EOI> <ffffffff804eed04>{__reacquire_kernel_lock+41}
[ 87.445394] <ffffffff804ed9ed>{thread_return+166} <ffffffff804ee015>{schedule_timeout+138}
[ 87.445552] <ffffffff8022a860>{process_timeout+0} <ffffffff804ecedf>{wait_for_completion_timeout+137}
[ 87.445712] <ffffffff8021ce63>{default_wake_function+0} <ffffffff80409406>{ata_exec_command+36}
[ 87.449155] <ffffffff804058bc>{ata_exec_internal+266} <ffffffff80406477>{ata_set_mode+667}
[ 87.449316] <ffffffff8023c6c5>{request_irq+130} <ffffffff804069f8>{ata_device_add+1163}
[ 87.449475] <ffffffff8040ba5f>{mv_init_one+1575} <ffffffff8036cafe>{pci_device_probe+221}
[ 87.449639] <ffffffff803bb8f1>{driver_probe_device+82} <ffffffff803bb9a6>{__driver_attach+0}
[ 87.449800] <ffffffff803bb9fc>{__driver_attach+86} <ffffffff803baeae>{bus_for_each_dev+67}
[ 87.449960] <ffffffff803bb1ae>{bus_add_driver+116} <ffffffff8036cb64>{pci_bus_match+0}
[ 87.450121] <ffffffff8036c664>{__pci_register_driver+85} <ffffffff8020720c>{init+455}
[ 87.450279] <ffffffff8020a6b6>{child_rip+8} <ffffffff80207045>{init+0}
[ 87.450423] <ffffffff8020a6ae>{child_rip+0}
[ 87.473659] ata5: dev 0 configured for UDMA/133
[ 87.473703] scsi4 : sata_mv
It happens for every port and only during boot.
It doesn't seem to have any negative effect on the server.
No crashes, no corruption.
Btw, sata_mv seems to work with CONFIG_PCI_MSI=y these days.
ISTR that caused problems in the past.
> Signed-Off-By Mark Lord <mlord@xxxxxxxxx>
>
> --- sata_mv.c.alignment 2006-03-19 15:14:29.000000000 -0500
> +++ sata_mv.c 2006-03-19 15:12:49.000000000 -0500
> @@ -1180,7 +1180,6 @@
> u32 hc_irq_cause;
> int shift, port, port0, hard_port, handled;
> unsigned int err_mask;
> - u8 ata_status = 0;
>
> if (hc == 0) {
> port0 = 0;
> @@ -1198,6 +1197,7 @@
> hc,relevant,hc_irq_cause);
>
> for (port = port0; port < port0 + MV_PORTS_PER_HC; port++) {
> + u8 ata_status = 0;
> ap = host_set->ports[port];
> hard_port = port & MV_PORT_MASK; /* range 0-3 */
> handled = 0; /* ensure ata_status is set if handled++ */
--
Humilis IT Services and Solutions
http://www.humilis.net
-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
