On Llu, 2006-03-20 at 20:56 -0500, Jeff Garzik wrote: > > So, ata_port_info uses pio/mwdma/udma_mask and ata_port and ata_device > > use single xfer_mask and all the masking constants are converted to > > mask single xfer_mask. Sounds good to you? > > Well, if I read him correctly, Alan seems to have weighted in on the > side of pio/mwdma/udma_mask. > > Maybe we could go with your original patches' direction for now, and > then move to a consolidated xfer_mask internally later. What I've done for the filter side of things is kept the combined mask as what is filtered by the driver, and that looks tidy. What came out ugly that I objected to was the horribly mess you got when declaring all the driver modes available. - : send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html