Re: LibPATA code issues / 2.6.15.4

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Albert Lee wrote:
How about the attached renaming patch?
It could make the command names more consistent to what's in the ATA/ATAPI spec.

---
Albert


Changes:

ATA_CMD_READ        => ATA_CMD_READ_DMA
ATA_CMD_WRITE       => ATA_CMD_WRITE_DMA
...
ATA_CMD_PIO_READ    => ATA_CMD_READ_PIO
ATA_CMD_PIO_WRITE   => ATA_CMD_WRITE_PIO
...
ATA_CMD_FPDMA_READ  => ATA_CMD_READ_FPDMA_QUEUED
ATA_CMD_FPDMA_WRITE => ATA_CMD_WRITE_FPDMA_QUEUED


Even given the current thread's confusion, I rather like the existing names. Everybody does DMA these days, so ATA_CMD_WRITE being of DMA protocol seems the most natural to me.

	Jeff


-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux