Re: [PATCH v4 0/12] ptrace: cleaning up ptrace_stop
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Oleg Nesterov <oleg@xxxxxxxxxx>
- Subject: Re: [PATCH v4 0/12] ptrace: cleaning up ptrace_stop
- From: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
- Date: Tue, 10 May 2022 09:26:36 -0500
- Cc: linux-kernel@xxxxxxxxxxxxxxx, rjw@xxxxxxxxxxxxx, mingo@xxxxxxxxxx, vincent.guittot@xxxxxxxxxx, dietmar.eggemann@xxxxxxx, rostedt@xxxxxxxxxxx, mgorman@xxxxxxx, bigeasy@xxxxxxxxxxxxx, Will Deacon <will@xxxxxxxxxx>, tj@xxxxxxxxxx, linux-pm@xxxxxxxxxxxxxxx, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Richard Weinberger <richard@xxxxxx>, Anton Ivanov <anton.ivanov@xxxxxxxxxxxxxxxxxx>, Johannes Berg <johannes@xxxxxxxxxxxxxxxx>, linux-um@xxxxxxxxxxxxxxxxxxx, Chris Zankel <chris@xxxxxxxxxx>, Max Filippov <jcmvbkbc@xxxxxxxxx>, linux-xtensa@xxxxxxxxxxxxxxxx, Jann Horn <jannh@xxxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, linux-ia64@xxxxxxxxxxxxxxx
- In-reply-to: <20220510141119.GA23277@redhat.com> (Oleg Nesterov's message of "Tue, 10 May 2022 16:11:21 +0200")
- References: <20220421150248.667412396@infradead.org> <20220421150654.817117821@infradead.org> <87czhap9dy.fsf@email.froward.int.ebiederm.org> <878rrrh32q.fsf_-_@email.froward.int.ebiederm.org> <87k0b7v9yk.fsf_-_@email.froward.int.ebiederm.org> <87k0b0apne.fsf_-_@email.froward.int.ebiederm.org> <87a6bv6dl6.fsf_-_@email.froward.int.ebiederm.org> <20220510141119.GA23277@redhat.com>
- User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
Oleg Nesterov <oleg@xxxxxxxxxx> writes:
> On 05/05, Eric W. Biederman wrote:
>>
>> Eric W. Biederman (11):
>> signal: Rename send_signal send_signal_locked
>> signal: Replace __group_send_sig_info with send_signal_locked
>> ptrace/um: Replace PT_DTRACE with TIF_SINGLESTEP
>> ptrace/xtensa: Replace PT_SINGLESTEP with TIF_SINGLESTEP
>> ptrace: Remove arch_ptrace_attach
>> signal: Use lockdep_assert_held instead of assert_spin_locked
>> ptrace: Reimplement PTRACE_KILL by always sending SIGKILL
>> ptrace: Document that wait_task_inactive can't fail
>> ptrace: Admit ptrace_stop can generate spuriuos SIGTRAPs
>> ptrace: Don't change __state
>> ptrace: Always take siglock in ptrace_resume
>>
>> Peter Zijlstra (1):
>> sched,signal,ptrace: Rework TASK_TRACED, TASK_STOPPED state
>
> OK, lgtm.
>
> Reviewed-by: Oleg Nesterov <oleg@xxxxxxxxxx>
>
>
> I still dislike you removed TASK_WAKEKILL from TASK_TRACED, but I can't
> find a good argument against it ;) and yes, this is subjective.
Does anyone else have any comments on this patchset?
If not I am going to apply this to a branch and get it into linux-next.
Eric
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]