Hi Christoph!
On 8/5/19 9:10 AM, Christoph Hellwig wrote:
> Seems like we dropped the ball on this..
>
> Did I give you a patch like this (for 5.2 and probably earlier, won't
> apply to 5.3-rc) to test before as that is anther idea?
>
> diff --git a/kernel/dma/direct.c b/kernel/dma/direct.c
> index 2c2772e9702a..e471158c7c6e 100644
> --- a/kernel/dma/direct.c
> +++ b/kernel/dma/direct.c
> @@ -119,7 +119,8 @@ struct page *__dma_direct_alloc_pages(struct device *dev, size_t size,
> }
> }
> if (!page)
> - page = alloc_pages_node(dev_to_node(dev), gfp, page_order);
> + page = alloc_pages_node(local_memory_node(dev_to_node(dev)),
> + gfp, page_order);
>
> if (page && !dma_coherent_ok(dev, page_to_phys(page), size)) {
> __free_pages(page, page_order);
I just applied this patch on top of 4.19.137 and it's crashing with this trace
when trying to load the "hpsa" module. It definitely looks like an issue with
dma_direct_alloc():
[ 2.352364] HP HPSA Driver (v 3.4.20-125)
[ 2.386832] hpsa 0000:02:00.0: Logical aborts not supported
[ 2.420644] hpsa 0000:02:00.0: HP SSD Smart Path aborts not supported
[ 2.482838] Unable to handle kernel NULL pointer dereference (address 0000000000001688)
[ 2.531221] swapper/0[1]: Oops 11012296146944 [1]
[ 2.535221] Modules linked in:
[ 2.535221]
[ 2.535221] CPU: 1 PID: 1 Comm: swapper/0 Not tainted 4.19.137-dirty #7
[ 2.535221] Hardware name: hp Integrity BL870c i4 nPar, BIOS 02.64 03/03/2016
[ 2.535221] psr : 00001210084a6010 ifs : 8000000000000207 ip : [<a00000010019acc1>] Not tainted (4.19.137-dirty)
[ 2.535221] ip is at local_memory_node+0x51/0xd0
[ 2.535221] unat: 0000000000000000 pfs : 0000000000000793 rsc : 0000000000000003
[ 2.535221] rnat: c00000005805cc60 bsps: 0000000000000000 pr : a6a6aa956aaa9959
[ 2.535221] ldrs: 0000000000000000 ccv : 0000000000000000 fpsr: 0009804c8a70433f
[ 2.535221] csd : 0000000000000000 ssd : 0000000000000000
[ 2.535221] b0 : a00000010011aab0 b6 : a00000010011c870 b7 : a00000010003a5e0
[ 2.535221] f6 : 10012bffff00000000000 f7 : 1003e00000000000bffff
[ 2.535221] f8 : 1003e0000000000002560 f9 : 1003e0000000000000054
[ 2.535221] f10 : 1003e00000000000000c0 f11 : 1003e0000000000003f00
[ 2.535221] r1 : a0000001013dd060 r2 : e000000001919980 r3 : e000000001919988
[ 2.535221] r8 : 0000000000000008 r9 : e000000001919990 r10 : 0000000000000000
[ 2.535221] r11 : 0000000000001688 r12 : e000000f8363fcc0 r13 : e000000f83638000
[ 2.535221] r14 : fffffffffffc04b8 r15 : 00000000ffffffff r16 : 0000000000ffffff
[ 2.535221] r17 : 0000000000000000 r18 : 0000000000000000 r19 : 0000000000000000
[ 2.535221] r20 : fffffffffffcdd50 r21 : 0000000000000010 r22 : e00000000114dd50
[ 2.535221] r23 : 0000000000000003 r24 : 0000000000000015 r25 : 0000000000000015
[ 2.535221] r26 : 0000000000000800 r27 : 0000000000000c00 r28 : a000000100f1f0e8
[ 2.535221] r29 : a00000010003a5e0 r30 : a00000010011c870 r31 : 0000000000000081
[ 2.535221]
[ 2.535221] Call Trace:
[ 2.535221] [<a000000100013570>] show_stack+0x40/0x90
[ 2.535221] sp=e000000f8363f870 bsp=e000000f83639838
[ 2.535221] [<a000000100013f80>] show_regs+0x9c0/0x9f0
[ 2.535221] sp=e000000f8363fa40 bsp=e000000f836397d0
[ 2.535221] [<a000000100024530>] die+0x1a0/0x2f0
[ 2.535221] sp=e000000f8363fa60 bsp=e000000f83639790
[ 3.750837] random: crng init done
[ 2.535221] [<a00000010004bb80>] ia64_do_page_fault+0x830/0x9d0
[ 2.535221] sp=e000000f8363fa60 bsp=e000000f836396f8
[ 2.535221] [<a00000010000c460>] ia64_leave_kernel+0x0/0x270
[ 2.535221] sp=e000000f8363faf0 bsp=e000000f836396f8
[ 2.535221] [<a00000010019acc0>] local_memory_node+0x50/0xd0
[ 2.535221] sp=e000000f8363fcc0 bsp=e000000f836396c0
[ 2.535221] [<a00000010011aab0>] dma_direct_alloc+0x110/0x280
[ 2.535221] sp=e000000f8363fcc0 bsp=e000000f83639648
[ 2.535221] [<a00000010011c8c0>] swiotlb_alloc+0x50/0x2a0
[ 2.535221] sp=e000000f8363fcc0 bsp=e000000f836395e8
[ 2.535221] [<a0000001007b4550>] hpsa_init_one+0x25f0/0x4670
[ 2.535221] sp=e000000f8363fcc0 bsp=e000000f83639320
[ 2.535221] [<a00000010056f6f0>] local_pci_probe+0x90/0x150
[ 2.535221] sp=e000000f8363fd40 bsp=e000000f836392e0
[ 2.535221] [<a000000100570dc0>] pci_device_probe+0x300/0x320
[ 2.535221] sp=e000000f8363fd40 bsp=e000000f836392a8
[ 2.535221] [<a0000001006c7a70>] really_probe+0x480/0x680
[ 2.535221] sp=e000000f8363fd60 bsp=e000000f83639240
[ 2.535221] [<a0000001006c8130>] driver_probe_device+0x1e0/0x1f0
[ 2.535221] sp=e000000f8363fd60 bsp=e000000f83639208
[ 2.535221] [<a0000001006c82d0>] __driver_attach+0x190/0x230
[ 2.535221] sp=e000000f8363fd60 bsp=e000000f836391d0
[ 2.535221] [<a0000001006c3950>] bus_for_each_dev+0xd0/0x130
[ 2.535221] sp=e000000f8363fd60 bsp=e000000f83639190
[ 2.535221] [<a0000001006c6ba0>] driver_attach+0x40/0x60
[ 2.535221] sp=e000000f8363fd70 bsp=e000000f83639170
[ 2.535221] [<a0000001006c60a0>] bus_add_driver+0x400/0x4a0
[ 2.535221] sp=e000000f8363fd70 bsp=e000000f83639120
[ 2.535221] [<a0000001006c9600>] driver_register+0x220/0x2b0
[ 2.535221] sp=e000000f8363fd70 bsp=e000000f836390f8
[ 2.535221] [<a00000010056ef80>] __pci_register_driver+0xa0/0xc0
[ 2.535221] sp=e000000f8363fd70 bsp=e000000f836390c8
[ 2.535221] [<a000000100f930b0>] hpsa_init+0x80/0xc0
[ 2.535221] sp=e000000f8363fd70 bsp=e000000f836390a0
[ 2.535221] [<a00000010000a6a0>] do_one_initcall+0x100/0x2d0
[ 2.535221] sp=e000000f8363fd70 bsp=e000000f83639068
[ 2.535221] [<a000000100f49c60>] kernel_init_freeable+0x5c0/0x5d0
[ 2.535221] sp=e000000f8363fdb0 bsp=e000000f83639000
[ 2.535221] [<a000000100c6a880>] kernel_init+0x20/0x280
[ 2.535221] sp=e000000f8363fe30 bsp=e000000f83638fd8
[ 2.535221] [<a00000010000c250>] call_payload+0x50/0x80
[ 2.535221] sp=e000000f8363fe30 bsp=e000000f83638fc0
[ 2.535221] Disabling lock debugging due to kernel taint
[ 5.711378] Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b
[ 5.711378]
[ 5.766837] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b
[ 5.766837] ]---
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaubitz@xxxxxxxxxx
`. `' Freie Universitaet Berlin - glaubitz@xxxxxxxxxxxxxxxxxxx
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
|