Re: [PATCH 40/41] drivers: tty: serial: helper for setting mmio range
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: "Enrico Weigelt\, metux IT consult" <info@xxxxxxxxx>
- Subject: Re: [PATCH 40/41] drivers: tty: serial: helper for setting mmio range
- From: Esben Haabendal <esben@xxxxxxxxxxxx>
- Date: Mon, 29 Apr 2019 09:03:16 +0200
- Cc: linux-kernel@xxxxxxxxxxxxxxx, gregkh@xxxxxxxxxxxxxxxxxxx, andrew@xxxxxxxx, andriy.shevchenko@xxxxxxxxxxxxxxx, macro@xxxxxxxxxxxxxx, vz@xxxxxxxxx, slemieux.tyco@xxxxxxxxx, khilman@xxxxxxxxxxxx, liviu.dudau@xxxxxxx, sudeep.holla@xxxxxxx, lorenzo.pieralisi@xxxxxxx, davem@xxxxxxxxxxxxx, jacmet@xxxxxxxxxx, linux@xxxxxxxxxxxxxxx, matthias.bgg@xxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, linux-serial@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-amlogic@xxxxxxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx
- In-reply-to: <1556369542-13247-41-git-send-email-info@metux.net> (Enrico Weigelt's message of "Sat, 27 Apr 2019 14:52:21 +0200")
- References: <1556369542-13247-1-git-send-email-info@metux.net> <1556369542-13247-41-git-send-email-info@metux.net>
- User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)
"Enrico Weigelt, metux IT consult" <info@xxxxxxxxx> writes:
> Introduce a little helpers for settings the mmio range from an
> struct resource or start/len parameters with less code.
> (also setting iotype to UPIO_MEM)
>
> Also converting drivers to use these new helpers as well as
> fetching mapsize field instead of using hardcoded values.
> (the runtime overhead of that should be negligible)
>
> The idea is moving to a consistent scheme, so later common
> calls like request+ioremap combination can be done by generic
> helpers.
Why not simply replace iobase, mapbase and mapsize with a struct
resource value instead?
Incidentally, that would allow to specify a memory resource with a
parent memory resource :)
/Esben
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]