Re: [PATCH 37/41] drivers: tty: serial: 8250: simplify io resource size computation
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>, "Enrico Weigelt, metux IT consult" <info@xxxxxxxxx>
- Subject: Re: [PATCH 37/41] drivers: tty: serial: 8250: simplify io resource size computation
- From: "Enrico Weigelt, metux IT consult" <lkml@xxxxxxxxx>
- Date: Mon, 29 Apr 2019 08:48:53 +0200
- Cc: linux-kernel@xxxxxxxxxxxxxxx, gregkh@xxxxxxxxxxxxxxxxxxx, andrew@xxxxxxxx, macro@xxxxxxxxxxxxxx, vz@xxxxxxxxx, slemieux.tyco@xxxxxxxxx, khilman@xxxxxxxxxxxx, liviu.dudau@xxxxxxx, sudeep.holla@xxxxxxx, lorenzo.pieralisi@xxxxxxx, davem@xxxxxxxxxxxxx, jacmet@xxxxxxxxxx, linux@xxxxxxxxxxxxxxx, matthias.bgg@xxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, linux-serial@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-amlogic@xxxxxxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx
- In-reply-to: <20190428152103.GP9224@smile.fi.intel.com>
- Organization: metux IT consult
- References: <1556369542-13247-1-git-send-email-info@metux.net> <1556369542-13247-38-git-send-email-info@metux.net> <20190428152103.GP9224@smile.fi.intel.com>
- User-agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1
On 28.04.19 17:21, Andy Shevchenko wrote:
>
>> +#define SERIAL_RT2880_IOSIZE 0x100
>
> And why this is in the header file and not in corresponding C one?
hmm, no particular reason, maybe just an old habit to put definitions
into .h files ;-)
I can move it to 8250_of.c if you like me to.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@xxxxxxxxx -- +49-151-27565287
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]
