Re: [Patch 5/8] ia64: implement crashkernel=auto
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Ingo Molnar <mingo@xxxxxxx>
- Subject: Re: [Patch 5/8] ia64: implement crashkernel=auto
- From: Bernhard Walle <bernhard.walle@xxxxxx>
- Date: Mon, 24 Aug 2009 10:21:49 +0200
- Cc: Amerigo Wang <amwang@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, tony.luck@xxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, nhorman@xxxxxxxxxx, ebiederm@xxxxxxxxxxxx, andi@xxxxxxxxxxxxxx, fenghua.yu@xxxxxxxxx, kamezawa.hiroyu@xxxxxxxxxxxxxx, avorontsov@xxxxxxxxxxxxx
- In-reply-to: <20090824074318.GB2424@xxxxxxx>
- List-id: <linux-ia64.vger.kernel.org>
- References: <20090821065637.4855.32234.sendpatchset@xxxxxxxxxxxxxxxxxxxxx> <20090821065729.4855.47860.sendpatchset@xxxxxxxxxxxxxxxxxxxxx> <20090821172407.d3a5cd2b.akpm@xxxxxxxxxxxxxxxxxxxx> <20090822111816.GA12281@xxxxxxx> <4A91F57D.10708@xxxxxxxxxx> <20090824074318.GB2424@xxxxxxx>
- User-agent: Mutt/1.5.20 (2009-06-14)
* Ingo Molnar <mingo@xxxxxxx> [2009-08-24 09:43]:
> * Amerigo Wang <amwang@xxxxxxxxxx> wrote:
> >
> > The reason that I kept 2ULL<<30 instead of 1ULL<<31 is that '1<<30' is
> > exactly 1G, so 2ULL<<30 can be easily read as 2G. ;)
>
> i have no trouble reading 1ULL<<31 as 2G ;-) OTOH, the logic and
> pattern of the comparisons (especially without the comment) looked
> odd at first sight, until i noticed this.
Why not just something like
#define KBYTE(x) ((x)*1024ULL)
#define MBYTE(x) ((x)*1024ULL*1024)
#define GBYTE(x) ((x)*1024ULL*1024*1024)
#define TBYTE(x) ((x)*1024ULL*1024*1024*1024)
I find GBYTE(2) much easier to read than 1ULL<<31. Honestly, I would
add a comment '/* 2G */' if I would write 1ULL<<31 in own code.
But I'm of course not one of that super kernel hackers. ;-)
Regards,
Bernhard
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]