Ingo Molnar wrote:
e) All the 'else' statements are superflous and make it all harder to read.f) 2ULL<<30 should be written as 1ULL<31, to keep things consistent.
Hi,The reason that I kept 2ULL<<30 instead of 1ULL<<31 is that '1<<30' is exactly 1G, so 2ULL<<30 can be easily read as 2G. ;)
g) A nice comment explaining the purpose and logic wouldnt hurt.
Yup, in fact patch 8/8 has the doc for this, but I will copy that here as a comment too.
Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-ia64" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|