Re: [Patch 5/8] ia64: implement crashkernel=auto
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Amerigo Wang <amwang@xxxxxxxxxx>
- Subject: Re: [Patch 5/8] ia64: implement crashkernel=auto
- From: Ingo Molnar <mingo@xxxxxxx>
- Date: Mon, 24 Aug 2009 09:43:18 +0200
- Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, tony.luck@xxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, nhorman@xxxxxxxxxx, ebiederm@xxxxxxxxxxxx, andi@xxxxxxxxxxxxxx, bernhard.walle@xxxxxx, fenghua.yu@xxxxxxxxx, kamezawa.hiroyu@xxxxxxxxxxxxxx, avorontsov@xxxxxxxxxxxxx
- In-reply-to: <4A91F57D.10708@xxxxxxxxxx>
- List-id: <linux-ia64.vger.kernel.org>
- References: <20090821065637.4855.32234.sendpatchset@xxxxxxxxxxxxxxxxxxxxx> <20090821065729.4855.47860.sendpatchset@xxxxxxxxxxxxxxxxxxxxx> <20090821172407.d3a5cd2b.akpm@xxxxxxxxxxxxxxxxxxxx> <20090822111816.GA12281@xxxxxxx> <4A91F57D.10708@xxxxxxxxxx>
- User-agent: Mutt/1.5.18 (2008-05-17)
* Amerigo Wang <amwang@xxxxxxxxxx> wrote:
> Ingo Molnar wrote:
>>
>> e) All the 'else' statements are superflous and make it all harder
>> to read.
>>
>> f) 2ULL<<30 should be written as 1ULL<31, to keep things consistent.
>>
>
> Hi,
>
> The reason that I kept 2ULL<<30 instead of 1ULL<<31 is that '1<<30' is
> exactly 1G, so 2ULL<<30 can be easily read as 2G. ;)
i have no trouble reading 1ULL<<31 as 2G ;-) OTOH, the logic and
pattern of the comparisons (especially without the comment) looked
odd at first sight, until i noticed this.
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]