Re: [PATCH v6 4/8] i2c: wmt: split out common files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andi,


On 2024/1/4 17:22, Andi Shyti wrote:
Hi Hans,

   MAINTAINERS                            |   2 +-
   drivers/i2c/busses/Makefile            |   2 +
   drivers/i2c/busses/i2c-viai2c-common.c | 234 ++++++++++++++
   drivers/i2c/busses/i2c-viai2c-common.h |  66 ++++
   drivers/i2c/busses/i2c-wmt-plt.c       | 137 ++++++++
'plt' stands for?

'plt' is short for 'platform', since it is not suitable,
it's suitable, sure... but not immediately understandable. Your
choice if you want to change it.

do you think it is better to change it to 'i2c-wmt-platform.c' or
'i2c-viai2c-wmt.c' ?
I would rename things to:

i2c-via-wmt.c
i2c-via-common.c
i2c-via-zhaoxin.c

But of course it's not binding.


if so, I choose to 'i2c-viai2c-*.c', because there's already a driver called 'i2c-via.c'.


Hans,

Andi




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux