Re: [PATCH v6 4/8] i2c: wmt: split out common files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2024/1/4 01:21, Andi Shyti wrote:
Hi Hans,

On Fri, Dec 29, 2023 at 02:30:35PM +0800, Hans Hu wrote:
Since the I2C IP of both wmt and zhaoxin come from VIA,
/come/comes/

the common driver is named as i2c-viai2c-common.c.
Old i2c-wmt.c renamed to i2c-wmt-plt.c.

The MAINTAINERS information will added in patch 0008.
when the patch is applied there is no knowledge anymore of the
patch sequence, please put these comments after the '---' section
or make it generic: "The MAINTAINERS file will be updated
accordingly in upcoming commits"


ok, will change this.


Signed-off-by: Hans Hu <hanshu-oc@xxxxxxxxxxx>
---
  MAINTAINERS                            |   2 +-
  drivers/i2c/busses/Makefile            |   2 +
  drivers/i2c/busses/i2c-viai2c-common.c | 234 ++++++++++++++
  drivers/i2c/busses/i2c-viai2c-common.h |  66 ++++
  drivers/i2c/busses/i2c-wmt-plt.c       | 137 ++++++++
'plt' stands for?


'plt' is short for 'platform', since it is not suitable,

do you think it is better to change it to 'i2c-wmt-platform.c' or 'i2c-viai2c-wmt.c' ?


Hans


Everything else looks correct.

Andi




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux