On 13/03/2023 09:48, Delphine_CC_Chiu/WYHQ/Wiwynn wrote: > Hi Krzysztof, > > Thanks for your review comment. > >> -----Original Message----- >> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> Sent: Tuesday, January 17, 2023 6:55 PM >> To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@xxxxxxxxxx>; >> patrick@xxxxxxxxx; Derek Kiernan <derek.kiernan@xxxxxxxxxx>; Dragan Cvetic >> <dragan.cvetic@xxxxxxxxxx>; Arnd Bergmann <arnd@xxxxxxxx>; Greg >> Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> >> Cc: garnermic@xxxxxx; Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof >> Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>; Stanislav Jakubek >> <stano.jakubek@xxxxxxxxx>; Linus Walleij <linus.walleij@xxxxxxxxxx>; Samuel >> Holland <samuel@xxxxxxxxxxxx>; linux-i2c@xxxxxxxxxxxxxxx; >> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx >> Subject: Re: [PATCH v1 3/3] misc: Add meta cld driver >> >> Security Reminder: Please be aware that this email is sent by an external >> sender. >> >> On 17/01/2023 10:44, Delphine CC Chiu wrote: >>> Add support for meta control-logic-device driver. The CLD manages the >>> server system power squence and other state such as host-power-state, >>> uart-selection and presense-slots. The baseboard management controller >>> (BMC) can access the CLD through I2C. >>> >>> The version 1 of CLD driver is supported. The registers number, name >>> and mode of CLD can be defined in dts file for version 1. The driver >>> exports the filesystem following the dts setting. >>> >>> Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@xxxxxxxxxx> >>> Tested-by: Bonnie Lo <Bonnie_Lo@xxxxxxxxxx> >>> --- >>> MAINTAINERS | 6 + >>> drivers/misc/Kconfig | 9 + >>> drivers/misc/Makefile | 1 + >>> drivers/misc/control-logic-device.c | 443 >>> ++++++++++++++++++++++++++++ >>> 4 files changed, 459 insertions(+) >>> create mode 100644 drivers/misc/control-logic-device.c >>> >>> diff --git a/MAINTAINERS b/MAINTAINERS index >>> 7483853880b6..46e250a2c334 100644 >>> --- a/MAINTAINERS >>> +++ b/MAINTAINERS >>> @@ -13388,6 +13388,12 @@ T: git git://linuxtv.org/media_tree.git >>> F: Documentation/devicetree/bindings/media/amlogic,gx-vdec.yaml >>> F: drivers/staging/media/meson/vdec/ >>> >>> +META CPLD DRIVER >>> +M: Delphine CC Chiu <Delphine_CC_Chiu@xxxxxxxxxx> >>> +L: linux-i2c@xxxxxxxxxxxxxxx >>> +S: Maintained >>> +F: >> Documentation/devicetree/bindings/misc/meta,control-logic-device.txt >> >> Missing entries for driver code. > > We saw there are entries defined in MAINTAINERS file(M, R, L, S, W, Q, B, C, P, T, F, X, N, K). > Could you guide us which entries are must to have? The driver paths. >>> obj-$(CONFIG_OPEN_DICE) += open-dice.o >>> obj-$(CONFIG_GP_PCI1XXXX) += mchp_pci1xxxx/ >>> obj-$(CONFIG_VCPU_STALL_DETECTOR) += vcpu_stall_detector.o >>> +obj-$(CONFIG_CONTROL_LOGIC_DEVICE) += control-logic-device.o >> >> Does not look like ordered by name. > > The file look like without ordered by name so we added the configuration in the tail. Indeed, but don't add stuff to the end. Conflict-prone. Best regards, Krzysztof
