On Thu, Nov 17, 2022 at 03:59:38PM +0800, Yinbo Zhu wrote: > Add the Loongson platform i2c binding with DT schema format using > json-schema. > > Signed-off-by: Yinbo Zhu <zhuyinbo@xxxxxxxxxxx> > --- > .../bindings/i2c/loongson,ls-i2c.yaml | 49 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 50 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i2c/loongson,ls-i2c.yaml > > diff --git a/Documentation/devicetree/bindings/i2c/loongson,ls-i2c.yaml b/Documentation/devicetree/bindings/i2c/loongson,ls-i2c.yaml > new file mode 100644 > index 000000000000..275afe8c8483 > --- /dev/null > +++ b/Documentation/devicetree/bindings/i2c/loongson,ls-i2c.yaml > @@ -0,0 +1,49 @@ > +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/i2c/loongson,ls-i2c.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Loongson I2C controller > + > +maintainers: > + - Yinbo Zhu <zhuyinbo@xxxxxxxxxxx> > + > +allOf: > + - $ref: /schemas/i2c/i2c-controller.yaml# > + > +properties: > + compatible: > + enum: > + - loongson,ls2k-i2c > + - loongson,ls7a-i2c > + > + interrupts: > + maxItems: 1 > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - "#address-cells" > + - "#size-cells" You can drop these 2. i2c-controller.yaml requires them. With that, Reviewed-by: Rob Herring <robh@xxxxxxxxxx>