Hi Terry, On Tue, 18 Jan 2022 14:22:34 -0600, Terry Bowman wrote: > The driver currently uses a CPU family match of 17h to determine > EFCH_PM_DECODEEN_WDT_TMREN register support. This family check will not > support future AMD CPUs and instead will require driver updates to add > support. > > Remove the family 17h family check and add a check for SMBus PCI > revision ID 0x51 or greater. The MMIO access method has been available > since at least SMBus controllers using PCI revision 0x51. This revision > check will support family 17h and future AMD processors including EFCH > functionality without requiring driver changes. > > Co-developed-by: Robert Richter <rrichter@xxxxxxx> > Signed-off-by: Robert Richter <rrichter@xxxxxxx> > Signed-off-by: Terry Bowman <terry.bowman@xxxxxxx> > To: Guenter Roeck <linux@xxxxxxxxxxxx> > To: linux-watchdog@xxxxxxxxxxxxxxx > To: Jean Delvare <jdelvare@xxxxxxxx> > To: linux-i2c@xxxxxxxxxxxxxxx > To: Wolfram Sang <wsa@xxxxxxxxxx> > To: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > To: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> > Cc: linux-kernel@xxxxxxxxxxxxxxx > Cc: Wim Van Sebroeck <wim@xxxxxxxxxxxxxxxxxx> > Cc: Robert Richter <rrichter@xxxxxxx> > Cc: Thomas Lendacky <thomas.lendacky@xxxxxxx> > --- > drivers/watchdog/sp5100_tco.c | 16 ++++------------ > drivers/watchdog/sp5100_tco.h | 1 + > 2 files changed, 5 insertions(+), 12 deletions(-) > (...) Looks good to me. Reviewed-by: Jean Delvare <jdelvare@xxxxxxx> -- Jean Delvare SUSE L3 Support
