Hi Terry, On Tue, 18 Jan 2022 14:22:30 -0600, Terry Bowman wrote: > This series uses request_mem_region() to synchronize accesses to the MMIO > registers mentioned above. request_mem_region() is missing the retry > logic in the case the resource is busy. As a result, request_mem_region() > will fail immediately if the resource is busy. The 'muxed' variant is > needed here but request_muxed_mem_region() is not defined to use. I will > follow up with another patch series to define the > request_muxed_mem_region() and use in both drivers. Shouldn't this be done the other way around, first introducing request_muxed_mem_region() and then using it directly in both drivers, rather than having a temporary situation where a failure can happen? As far as I'm concerned, the patch series you just posted are acceptable only if request_muxed_mem_region() gets accepted too. Otherwise we end up with the situation where a driver could randomly fail. -- Jean Delvare SUSE L3 Support
