> > drivers/i2c/busses/i2c-cp2615.c:78:5: warning: symbol 'cp2615_init_iop_msg' was not declared. Should it be static? > > drivers/i2c/busses/i2c-cp2615.c:96:5: warning: symbol 'cp2615_init_i2c_msg' was not declared. Should it be static? > > drivers/i2c/busses/i2c-cp2615.c:102:5: warning: symbol 'cp2615_check_status' was not declared. Should it be static? > I can forward declare these (copying from the header I used in v1 of > the patch), but I'm not sure I understand the rationale behind these > warnings... Just make them static and all is good. > > drivers/i2c/busses/i2c-cp2615.c:212:27: warning: symbol 'cp2615_i2c_quirks' was not declared. Should it be static? > Especially this. I think I will make this static instead, since it > won't ever be exported to any other module. Exactly. > > The missing 'static' are what buildbot also reported and are correct. > The lkp bot complained about MODULE_DEVICE_TABLE and MODULE_AUTHOR, > which, again, I don't see what is wrong with it. Yeah, that may be a false positive. > I will now send an updated patch, with few additions too. Cool, thanks!
Attachment:
signature.asc
Description: PGP signature
