Re: [PATCH] i2c: rcar: implement atomic transfers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 18, 2021 at 05:03:41PM +0100, Ulrich Hecht wrote:
> 
> > On 02/18/2021 11:49 AM Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote:
> > > Implements atomic transfers. Tested by rebooting an r8a7790 Lager board
> > > after connecting the i2c-rcar controller to the PMIC in
> > > arch/arm/boot/dts/r8a7790-lager.dts like so:
> > > 
> > > 		compatible = "i2c-demux-pinctrl";
> > > 		pinctrl-names = "default";
> > > 		pinctrl-0 = <&pmic_irq_pins>;
> > > -		i2c-parent = <&iic3>, <&i2c3>;
> > > +		i2c-parent = <&i2c3>, <&iic3>;
> > > 		i2c-bus-name = "i2c-pwr";
> > > 		#address-cells = <1>;
> > > 		#size-cells = <0>;
> > > 
> > > Signed-off-by: Ulrich Hecht <uli+renesas@xxxxxxxx>
> > 
> > Doesn't apply against 5.11 or i2c/for-next. What is the base here?
> 
> renesas-drivers-2021-02-09-v5.11-rc7

Ok, now it applies, good. Testing went also fine, works nicely.

From a maintaining perspective, I think, though, we should have only one
master_xfer() function and use 'atomic_xfer' in there to skip stuff etc.
Otherwise fixes in one function might be forgotten in the other one. Or?

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux