On Wed, Feb 17, 2021 at 03:47:01PM +0200, Andy Shevchenko wrote: > On Wed, Feb 17, 2021 at 07:40:14PM +0800, Dejin Zheng wrote: > > On Tue, Feb 16, 2021 at 06:46:01PM +0100, Krzysztof Wilczyński wrote: > > ... > > > > The change simplifies the error handling path, how? A line of two which > > > explains how it has been achieved might help should someone reads the > > > commit message in the future. > > > > > To put it simply, if the driver probe fail, the device-managed function > > mechanism will automatically call pcim_release(), then the pci_free_irq_vectors() > > will be executed. For details, please see the relevant code. > > Perhaps as a compromise you may add this short sentence to your commit > messages, like "the freeing resources will take automatically when device > is gone". > Ok, I will do it. Andy, Thanks for your help. And so sorry for the late reply. Yesterday was the last day of the Chinese New Year holiday. There were a lot of things to deal with. BR, Dejin > -- > With Best Regards, > Andy Shevchenko > >
