Re: [PATCH] i2cset: Fix short writes with mask

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 8 Sep 2020 17:40:29 +0200, Wolfram Sang wrote:
> Hi Jean,
> 
> > Funny story, while I only posted this last week, I wrote the fix
> > several months ago, so last week I actually got to review my own code
> > with fresh eyes, and when I stumbled upon that specific change, first
> > thing that came to my mind was "this is a useless change, why did I do
> > that ?" Then I scrolled up, checked the other changes in that function,
> > noticed the removed "else" and said OK, I'm not that stupid after all
> > ;-)  
> 
> :) Now that there are two of us, maybe this justifies a short comment
> explaining it?

Well, the code itself isn't tricky, and it's only more of the same,
nothing new. The surprise was only for the patch reviewers, and now
this is cleared, and I committed the patch already. So I don't think
there's anything left to do.

Thanks,
-- 
Jean Delvare
SUSE L3 Support



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux