On Thu, Sep 03, 2020 at 11:00:54AM +0200, Jean Delvare wrote: > Short writes used "daddress" for the value, but the masking code did > not expect that, and instead applied the mask to a variable that was > never used. > > So change short writes to use "value" for the value, as all other > commands do. Adjust all code paths accordingly. > > Reported by David Jedynak. > > Signed-off-by: Jean Delvare <jdelvare@xxxxxxx> Reviewed-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> Tested-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> Passed my test as well. One question: > @@ -140,7 +140,7 @@ static int confirm(const char *filename, > } else > fprintf(stderr, "data 0x%02x%s, mode %s.\n", value, > vmask ? " (masked)" : "", > - size == I2C_SMBUS_BYTE_DATA ? "byte" : "word"); > + size == I2C_SMBUS_WORD_DATA ? "word" : "byte"); Does this really change something or is it a refactoring leftover?
Attachment:
signature.asc
Description: PGP signature
