Re: [PATCH v1 1/2] i2c: designware: Make master module optional

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > Size of i2c-designware-core.ko is around 12 kB with all master, slave and
> > Baytrail semaphore code built in so I don't think it justifies the added
> > config complexity. I think distributions will have anyway all of those
> > options set.
> 
> I would rather go with conditional based on I²C generic options, like I2C_SLAVE.
> Do we have something similar for master?

No, we don't have that.

> 
> > Having those code in separate modules and load only when needed might make
> > sense as that would save a few kB of RAM.
> 
> ...which makes sense for embedded systems where exactly the device represents
> I²C slave.

Frankly: an I2C-slave-only embedded system which runs a modern Linux and
cannot afford those few KB on a core feature it needs? If so, maybe it
should have an out-of-tree patch to achieve this. I don't think it is
worth the added complexity for the upstream version.

Sidenote: There is a lot more overhead in the i2c-core. I think the
complexity to move out stuff there is even more messy.

Disclaimer: you may prove me wrong, of course :)

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux