On Wed, Mar 25, 2020 at 09:47:47AM +0200, Jarkko Nikula wrote: > On 3/23/20 12:04 PM, Andy Shevchenko wrote: > > In some cases we know that the controller will be always used in slave mode and > > master is just a bulk. In order to drop that, introduce a separate configuration > > parameter for master mode. Default it to core to avoid regressions. > I think we should go to a opposite direction - reduce the number of > I2C_DESIGNWARE_ config options rather than add new ones. We already have 5 > config options for it. > > Size of i2c-designware-core.ko is around 12 kB with all master, slave and > Baytrail semaphore code built in so I don't think it justifies the added > config complexity. I think distributions will have anyway all of those > options set. I would rather go with conditional based on I²C generic options, like I2C_SLAVE. Do we have something similar for master? > Having those code in separate modules and load only when needed might make > sense as that would save a few kB of RAM. ...which makes sense for embedded systems where exactly the device represents I²C slave. -- With Best Regards, Andy Shevchenko
