On Thu, Mar 05, 2020 at 09:19:05PM +0000, Peter Rosin wrote: > On 2020-03-05 16:53, Andy Shevchenko wrote: > > There is no need to perform a check for optional GPIO descriptor. > > If it's NULL, the API can handle it correctly. > > But, the removed test is not only (needlessly) protecting the optional > descriptor, it also shortcuts the udelays. I think it is valid to > skip those pointless udelays when no reset is happening anyway. Not > that it matters all that much when the delays are as short as this, but > I simply think it looks sensible to skip the delays when that are not > needed. Perhaps moving it to a helper where we may leave the check. > So, I do not think this change is an improvement. I have no strong opinion, I simple will drop it then. Thank you for review! -- With Best Regards, Andy Shevchenko
