Hi!
On 2020-03-05 16:53, Andy Shevchenko wrote:
> Refactor pca954x_irq_handler() to:
> - use for_each_set_bit() macro
> - use IRQ_RETVAL() macro
>
> Above change makes code easy to read and understand.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> drivers/i2c/muxes/i2c-mux-pca954x.c | 17 +++++++----------
> 1 file changed, 7 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/i2c/muxes/i2c-mux-pca954x.c b/drivers/i2c/muxes/i2c-mux-pca954x.c
> index a0d926ae3f86..819ff95e64ba 100644
> --- a/drivers/i2c/muxes/i2c-mux-pca954x.c
> +++ b/drivers/i2c/muxes/i2c-mux-pca954x.c
> @@ -327,21 +327,18 @@ static DEVICE_ATTR_RW(idle_state);
> static irqreturn_t pca954x_irq_handler(int irq, void *dev_id)
> {
> struct pca954x *data = dev_id;
> - unsigned int child_irq;
> - int ret, i, handled = 0;
> + unsigned long pending;
> + int ret, i;
>
> ret = i2c_smbus_read_byte(data->client);
> if (ret < 0)
> return IRQ_NONE;
>
> - for (i = 0; i < data->chip->nchans; i++) {
> - if (ret & BIT(PCA954X_IRQ_OFFSET + i)) {
> - child_irq = irq_linear_revmap(data->irq, i);
> - handle_nested_irq(child_irq);
> - handled++;
> - }
> - }
> - return handled ? IRQ_HANDLED : IRQ_NONE;
> + pending = ret >> PCA954X_IRQ_OFFSET;
> + for_each_set_bit(i, &pending, data->chip->nchans)
> + handle_nested_irq(irq_linear_revmap(data->irq, i));
> +
> + return IRQ_RETVAL(pending);
What if ret has some bit set above the bit corresponding to the last channel?
Maybe that's somehow not possible, but if that's the case it's not apparent.
Cheers,
Peter
> }
>
> static int pca954x_irq_set_type(struct irq_data *idata, unsigned int type)
>
