Re: [PATCH] i2c: designware-pci: Remove needless pci_set_master() call

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx> writes:

> On 9/6/19 3:43 PM, Mika Westerberg wrote:
>> On Fri, Sep 06, 2019 at 03:40:29PM +0300, Jarkko Nikula wrote:
>>> I failed to notice the pci_set_master() call is needless in the
>>> commit 21aa3983d619 ("i2c: designware-pci: Switch over to MSI interrupts")
>>> due the fact driver don't support DMA.
>> 
>> Hmm, MSI still needs bus mastering to be enabled, no?
>> 
> At least Documentation/PCI/msi-howto.rst doesn't mention it and I think 
> I saw some commit adding MSI support without pci_set_master() but I'll 
> dig more.

Read PCI documentation (see attached)

Attachment: pci-bus-master.png
Description: PNG image


-- 
balbi

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux