Re: [PATCH] i2c: designware-pci: Remove needless pci_set_master() call

[Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx>]

On 9/6/19 3:43 PM, Mika Westerberg wrote:
> On Fri, Sep 06, 2019 at 03:40:29PM +0300, Jarkko Nikula wrote:
> > I failed to notice the pci_set_master() call is needless in the
> > commit 21aa3983d619 ("i2c: designware-pci: Switch over to MSI interrupts")
> > due the fact driver don't support DMA.
>
> Hmm, MSI still needs bus mastering to be enabled, no?
At least Documentation/PCI/msi-howto.rst doesn't mention it and I think 
I saw some commit adding MSI support without pci_set_master() but I'll 
dig more.

--
Jarkko