On Wed, Jun 05, 2019 at 08:15:35AM +0000, Peter Rosin wrote: > On 2019-06-05 00:43, Serge Semin wrote: > > On Tue, Jun 04, 2019 at 09:06:22PM +0000, Peter Rosin wrote: > >> On 2019-06-04 00:08, Linus Walleij wrote: > > 2. My patchset splits platform_data-based and OF-based code up, which improves the > > i2c-mux-gpio driver readability. Linus' patch doesn't provide the same way of > > simplification, but no doubt simplify the code a bit. > > So, I had a closer look, and yes, your patches do split up the of and > plat code. But is this the right approach? The only user of the plat > interface is the i2c-i801 driver (and I would really like for the > plat interface to just go away). Linus' approach seem (to at least > attempt) to consolidate the plat and of code paths so that the > i2c-mux-gpio code can ignore the platform interface and only > work with the gpiod interface. I like that. I second the idea of drop legacy platform data support. -- With Best Regards, Andy Shevchenko