Re: [PATCH RFT] i2c: designware: ratelimit 'transfer when suspended' errors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 24, 2019 at 11:54:17PM +0300, skidnik wrote:
> > There are two problems with dev_err() here. One: It is not ratelimited.
> > Two: We don't see which driver tried to transfer something with a
> > suspended adapter. Switch to dev_WARN_ONCE to fix both issues. Drawback
> > is that we don't see if multiple drivers are trying to transfer while
> > suspended. They need to be discovered one after the other now. This is
> > better than a high CPU load because a really broken driver might try to
> > resend endlessly.
> > 
> > Link: https://bugs.archlinux.org/task/62391
> > Fixes: 275154155538 ("i2c: designware: Do not allow i2c_dw_xfer() calls while suspended")
> > Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
...
> I have little experience in compiling and applying patches, guess I can add
> this diff as a patch to linux-mainline PKGBUILD and try to build it. I'll
> try.

Great, thanks for trying!

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux