>From a functional standpoint, it is simply doing the same operation that it does today, just with different APIs, so that's fine. I will go and test it to make sure it works on RZ/A1 and RZ/A2 and didn't break anything, and then reply. Chris > -----Original Message----- > From: Wolfram Sang <wsa@xxxxxxxxxxxxx> > Sent: Monday, April 15, 2019 8:17 AM > To: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > Cc: Chris Brandt <Chris.Brandt@xxxxxxxxxxx>; linux-i2c@xxxxxxxxxxxxxxx; > linux-renesas-soc@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] i2c: riic: Add Runtime PM support > > On Wed, Mar 20, 2019 at 11:30:03AM +0100, Geert Uytterhoeven wrote: > > - Replace explicit clock handling by Runtime PM calls, > > - Streamline Runtime PM handling in error paths, > > - Enable Runtime PM in .probe(), > > - Disable Runtime PM in .remove(), > > - Make sure the device is runtime-resumed when disabling interrupts in > > .remove(). > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > --- > > I don't think it's worth splitting off the last bug fix in a separate > > (first) patch, using explicit clock handling, as that will be replaced > > immediately by Runtime PM calls. > > Chris, what do you think about this patch?
