Hello all,
With v4.19-rc6, I am seeing the splat below, which I *think* may be caused by
commit 3bd4f277274bd7dde65879e5c8cd16d0b34eba90
Author: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx>
Date: Tue Jun 19 14:23:21 2018 +0300
i2c: designware: Call i2c_dw_clk_rate() only once in i2c_dw_init_master()
This is rather readability update than micro-optimization, or if not
optimization at all. We take the input clock rate to a variable and pass
that to SCL timing parameter calculation functions.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Signed-off-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx>
Signed-off-by: Wolfram Sang <wsa@xxxxxxxxxxxxx>
Note that this is an arm64 ACPI system.
Cheers,
Ard.
WARNING: CPU: 3 PID: 1 at
/home/ard/linux-2.6/drivers/i2c/busses/i2c-designware-common.c:245
i2c_dw_clk_rate+0x38/0x50
Modules linked in:
CPU: 3 PID: 1 Comm: swapper/0 Not tainted 4.19.0-rc6+ #27
Hardware name: AMD Seattle/Seattle, BIOS 18:14:32 May 22 2018
pstate: 60400005 (nZCv daif +PAN -UAO)
pc : i2c_dw_clk_rate+0x38/0x50
lr : i2c_dw_probe+0x84/0x518
sp : ffff00000b163af0
x29: ffff00000b163af0 x28: 0000000000000005
x27: ffff2fbb24bc5000 x26: ffff2fbb24480764
x25: ffffc9d77a90d130 x24: ffffc9d77a90d0c0
x23: ffff2fbb24a08000 x22: ffffc9d77a904000
x21: ffffc9d77a8fd800 x20: 0000000000000000
x19: ffffc9d77a90d018 x18: ffffffffffffffff
x17: 0000000000000000 x16: 0000000000000000
x15: ffff2fbb24a08708 x14: ffff2fbb243f9000
x13: ffffc9d77a8ac154 x12: 0000000000000018
x11: 0000000000000000 x10: 0101010101010101
x9 : 0000000000000000 x8 : ffffc9d77a93e300
x7 : 0000000000000000 x6 : 000000000000003f
x5 : ffffc9d77a93ee80 x4 : ffffc9d77ff500e0
x3 : 0000000000000000 x2 : ffff00000b195000
x1 : 0000000000000000 x0 : ffff2fbb23d41dac
Call trace:
i2c_dw_clk_rate+0x38/0x50
i2c_dw_probe+0x84/0x518
dw_i2c_plat_probe+0x30c/0x650
platform_drv_probe+0x58/0xa8
really_probe+0x24c/0x3a8
driver_probe_device+0x12c/0x148
__driver_attach+0x118/0x140
bus_for_each_dev+0x84/0xd8
driver_attach+0x30/0x40
bus_add_driver+0x174/0x2a8
driver_register+0x64/0x110
__platform_driver_register+0x54/0x60
dw_i2c_init_driver+0x20/0x28
do_one_initcall+0x54/0x268
kernel_init_freeable+0x2d4/0x380
kernel_init+0x18/0x118
ret_from_fork+0x10/0x18
---[ end trace c306c083da2359d2 ]---
