On Fri, Sep 21, 2018 at 10:46 AM Jae Hyun Yoo <jae.hyun.yoo@xxxxxxxxxxxxxxx> wrote: > > Hi Brendan, > > nit: > Title in imperative mood. I'd put 'fix' instead of 'fixed'. > <snip> > > One minor issue is, 'base_clk_divisor' instead of 'base_clk' could avoid > misreading on this code. > > With that, it looks nice to me. Thanks! > > Reviewed-by: Jae Hyun Yoo <jae.hyun.yoo@xxxxxxxxxxxxxxx> Thanks for the review!