Hi Heikki and Peter, > > > Can we get the working set in while the issues is being debugged? > > > > I'm not the one making the decision, and I don't even know if this is > > going through the i2c or the usb tree? If it's going through the i2c > > tree you need a tag from the usb people (Greg?) on patch 2/2, and if > > it's going through the usb tree, you need a tag from Wolfram on patch > > 1/2. As I said, I'm not involved with that part, I'm just reviewing > > these patches because I felt like it. > > > > The remaining issue that bothers me is the looping reads, and your > > email address reveals that you should be in a very good position to > > work out why they do not work, and fix it or let us know why they > > don't. I am working with different teams to debug this and I think it may take some time to know the root cause. >> However, your responses indicate that you have given up. That > > coupled with the fact that the datasheet is not publicly available > > (but why, seems a little over-protective to think the interface to an > > i2c controller is worth all that much) makes me think that perhaps > > this little detail might never be fixed if it's not fixed now. Once > > merged, there is no pressure on you to actually do anything about it, > > and others are stuck in darkness without a spec. > > I got similar impression. Ajay, you have really made it look like you just want > to dump the code even though it still has problems, then lift your arms and > never look back. I'm sure that is not the case, but the fact that you are > continuously making pleas, asking us to just accept the code even though it is > not ready, does give that impression. > I can appreciate that you are in a hurry, and I know you have a lot of other > tasks that also need your attention, just like everybody, but I'm asking you to > take a deep breath, and take one more look at these two drivers. Go over the > code as a whole instead of trying to fix the problems as fast as possible > (you've sent a new version almost daily). > I'm certain you can figure out how to fix that last issue. You are almost there. > > And when you are ready, please include a cover letter in your next version and > provide some background for these patches if you can. Ok. Thanks Ajay --nvpublic > Ideally you could tell something about the platform that has that the PD > controller and the I2C host. There you can also mention which tree you think > these patches should go through, usb or i2c. I'm guessing usb based on the > fact that the I2C host controller driver seems to be there just for the USB PD > controller, at least for now. > > > Thanks, > > -- > heikki
