Hi Shubhrajyoti, On Fri, Sep 7, 2018 at 3:24 AM, Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxxxx> wrote: >> diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c-aspeed.c >> index a4f956c..3d236d2 100644 >> --- a/drivers/i2c/busses/i2c-aspeed.c >> +++ b/drivers/i2c/busses/i2c-aspeed.c >> @@ -558,13 +558,12 @@ static irqreturn_t aspeed_i2c_bus_irq(int irq, void *dev_id) >> if (aspeed_i2c_slave_irq(bus)) { >> dev_dbg(bus->dev, "irq handled by slave.\n"); >> ret = true; > Do you need the assignment now Good catch! I sent a v2 without it, thanks.