Re: [PATCH] i2c: aspeed: Remove label only used when CONFIG_I2C_SLAVE=y

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri, Sep 7, 2018 at 2:45 AM Fabio Estevam <festevam@xxxxxxxxx> wrote:
>
> From: Fabio Estevam <fabio.estevam@xxxxxxx>
>
> When CONFIG_I2C_SLAVE is not selected the following build warning
> is seen:
>
> drivers/i2c/busses/i2c-aspeed.c:567:1: warning: label 'out' defined but not used [-Wunused-label]
>
> Get rid of the 'out' label by moving the corresponding functions
> directly inside aspeed_i2c_bus_irq().
>
> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxx>
> ---
>  drivers/i2c/busses/i2c-aspeed.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c-aspeed.c
> index a4f956c..3d236d2 100644
> --- a/drivers/i2c/busses/i2c-aspeed.c
> +++ b/drivers/i2c/busses/i2c-aspeed.c
> @@ -558,13 +558,12 @@ static irqreturn_t aspeed_i2c_bus_irq(int irq, void *dev_id)
>         if (aspeed_i2c_slave_irq(bus)) {
>                 dev_dbg(bus->dev, "irq handled by slave.\n");
>                 ret = true;
Do you need the assignment now


> -               goto out;
> +               spin_unlock(&bus->lock);
> +               return IRQ_HANDLED;
>         }
>  #endif /* CONFIG_I2C_SLAVE */
>
>         ret = aspeed_i2c_master_irq(bus);
> -
> -out:
>         spin_unlock(&bus->lock);
>         return ret ? IRQ_HANDLED : IRQ_NONE;
>  }
> --
> 2.7.4
>



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux