On Mon, Mar 19, 2018 at 5:21 PM, Bartosz Golaszewski <brgl@xxxxxxxx> wrote: > 2018-03-19 15:43 GMT+01:00 Andy Shevchenko <andy.shevchenko@xxxxxxxxx>: >> On Mon, Mar 19, 2018 at 11:17 AM, Bartosz Golaszewski <brgl@xxxxxxxx> wrote: >>> This series contains what I hope to be a non-controversial refactoring >>> of the at24 eeprom driver. >>> >>> Most changes revolve around at24_probe() which became quite complicated >>> and hard to read. >>> >>> The only functional changes are: disabling the internal locking >>> mechanisms of regmap (since we already take care of that in the driver) >>> and removing an if checking if byte_len is a power of 2 (as we do >>> support models for which it's not true). >>> >>> All other patches affect readability and code structure. >>> >>> Tested with a couple models and different both for device tree and >>> platform data modes. >> >> Is there any available tree with that series applied? >> I would test it on Intel Galileo Gen 2 which has ACPI enumerated AT24 >> EEPROM attached. >> > > Yes, it's in my github tree: > > https://github.com/brgl/linux topic/at24/refactoring > > Thanks in advance for testing it! At least this didn't break AT24 on Intel Galileo Gen 2 board in ACPI mode. Tested-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> -- With Best Regards, Andy Shevchenko
