Re: [PATCH] i2c-qup: reduce verbosity on DMA channel not found messages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Withdrawing patch.

After review, the correct solution to the unnecessary logging seen on some targets is to provide a different path through the probe function for ACPI devices.

A more correct patch will be sent soon.


On 1/16/2018 2:35 PM, Austin Christ wrote:
From: Sinan Kaya <okaya@xxxxxxxxxxxxxx>

QDF2400 product doesn't have any BAM DMA attached to the I2C channel. This
causes code to spit an unnecessary error message during boot.

Signed-off-by: Sinan Kaya <okaya@xxxxxxxxxxxxxx>
Signed-off-by: Austin Christ <austinwc@xxxxxxxxxxxxxx>
---
  drivers/i2c/busses/i2c-qup.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c
index 08f8e01..c28d267 100644
--- a/drivers/i2c/busses/i2c-qup.c
+++ b/drivers/i2c/busses/i2c-qup.c
@@ -666,7 +666,7 @@ static int qup_i2c_req_dma(struct qup_i2c_dev *qup)
  		if (IS_ERR(qup->btx.dma)) {
  			err = PTR_ERR(qup->btx.dma);
  			qup->btx.dma = NULL;
-			dev_err(qup->dev, "\n tx channel not available");
+			dev_info(qup->dev, "\n tx channel not available");
  			return err;
  		}
  	}
@@ -674,7 +674,7 @@ static int qup_i2c_req_dma(struct qup_i2c_dev *qup)
  	if (!qup->brx.dma) {
  		qup->brx.dma = dma_request_slave_channel_reason(qup->dev, "rx");
  		if (IS_ERR(qup->brx.dma)) {
-			dev_err(qup->dev, "\n rx channel not available");
+			dev_info(qup->dev, "\n rx channel not available");
  			err = PTR_ERR(qup->brx.dma);
  			qup->brx.dma = NULL;
  			qup_i2c_rel_dma(qup);


--
Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux