On Tue, Jan 16, 2018 at 3:35 PM, Austin Christ <austinwc@xxxxxxxxxxxxxx> wrote:
> From: Sinan Kaya <okaya@xxxxxxxxxxxxxx>
>
> QDF2400 product doesn't have any BAM DMA attached to the I2C channel. This
> causes code to spit an unnecessary error message during boot.
If that's the case, then qup->is_dma should be false, and then this
code should never be executed.
Wouldn't it be better if qup_i2c_probe() is modified to detect a
QDF2400 and not even try to enable DMA? There's already code like
that for device tree:
if (of_device_is_compatible(pdev->dev.of_node, "qcom,i2c-qup-v1.1.1")) {
qup->adap.algo = &qup_i2c_algo;
qup->adap.quirks = &qup_i2c_quirks;
else
...
qup->adap.algo = &qup_i2c_algo_v2;
ret = qup_i2c_req_dma(qup);
On QDF2400, you should never be calling qup_i2c_req_dma() in the first place.
