Re: [PATCH] i2c: s3c2410: Properly handle interrupts of number 0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH] i2c: s3c2410: Properly handle interrupts of number 0
From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Date: Fri, 2 Mar 2018 15:26:56 +0300
Cc: Krzysztof Kozlowski <krzk@xxxxxxxxxx>, Kukjin Kim <kgene@xxxxxxxxxx>, Wolfram Sang <wsa@xxxxxxxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-samsung-soc@xxxxxxxxxxxxxxx, linux-i2c@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, stable@xxxxxxxxxxxxxxx, Ben Dooks <ben-linux@xxxxxxxxx>
In-reply-to: <20180302121929.GY9418@n2100.armlinux.org.uk>
References: <1519936484-23132-1-git-send-email-krzk@kernel.org> <20180302111931.GX9418@n2100.armlinux.org.uk> <20180302114909.u6kqdszt3aew2io2@mwanda> <20180302121929.GY9418@n2100.armlinux.org.uk>
User-agent: NeoMutt/20170609 (1.8.3)

Ok, but in that case the original code is still wrong because it returns
early with success.  I guess it could be changed to:

	if (irq <= 0)
		return -ENXIO;

regards,
dan carpenter

Follow-Ups:
- Re: [PATCH] i2c: s3c2410: Properly handle interrupts of number 0
  - From: Russell King - ARM Linux

References:
- [PATCH] i2c: s3c2410: Properly handle interrupts of number 0
  - From: Krzysztof Kozlowski
- Re: [PATCH] i2c: s3c2410: Properly handle interrupts of number 0
  - From: Russell King - ARM Linux
- Re: [PATCH] i2c: s3c2410: Properly handle interrupts of number 0
  - From: Dan Carpenter
- Re: [PATCH] i2c: s3c2410: Properly handle interrupts of number 0
  - From: Russell King - ARM Linux

Prev by Date: Re: [PATCH] i2c: s3c2410: Properly handle interrupts of number 0
Next by Date: Re: [PATCH] i2c: s3c2410: Properly handle interrupts of number 0
Previous by thread: Re: [PATCH] i2c: s3c2410: Properly handle interrupts of number 0
Next by thread: Re: [PATCH] i2c: s3c2410: Properly handle interrupts of number 0
Index(es):
- Date
- Thread

[Index of Archives] [Linux GPIO] [Linux SPI] [Linux Hardward Monitoring] [LM Sensors] [Linux USB Devel] [Linux Media] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI]