Re: Patch proposal for using all addresses in i2c-tools

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 27, 2018 at 08:15:04AM +0100, Peter Rosin wrote:
> On 2018-02-26 21:42, Wolfram Sang wrote:
> > On Mon, Feb 26, 2018 at 08:49:18PM +0100, Wolfram Sang wrote:
> >> On Fri, Feb 02, 2018 at 01:45:15PM +0100, Romain Porte wrote:
> >>> This new patchset mainly removes any references to 'risky' addresses,
> >>> but uses the 'all' addresses instead. This reflects the name of the
> >>> chosen '-a' option that is already present in i2cdetect.
> >>>
> >>> Changes from previous version:
> >>>
> >>>  - Use 'all_addrs' name instead of 'risky_addr'
> >>>  - Remove 'risky' mentions in man pages
> >>>  - Remove 'risky' mentions in commits
> >>>
> >>> Please review.
> >>
> >> Well, I like the change and visually reviewed the code. From that:
> >>
> >> Acked-by: Wolfram Sang <wsa@xxxxxxxxxxxxx>
> >>
> >> Hopefully, I'll have some time later to actually test the code and
> >> upgrade to "Reviewed-by"... Peter seemed happy, too. However, I'd like
> >> to get some response from Jean.
> > 
> > Or let's try to offload stuff from Jean: Peter, if you'd have time to test
> > this code and donate a tag, I can push it to the i2c-tools repo.
> 
> I can offer a 
> 
> Reviewed-by: Peter Rosin <peda@xxxxxxxxxx>

That's good already, thanks!

Maybe someone else on the list has some time for testing. I'll try, too,
but can't really say when...

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux