On Wed, Feb 21, 2018 at 4:21 AM, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > Hi Laurent, > > On Wed, Feb 21, 2018 at 12:10 AM, Laurent Pinchart > <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> wrote: >> From: Pantelis Antoniou <pantelis.antoniou@xxxxxxxxxxxx> >> >> Changesets are very powerful, but the lack of a helper API >> makes using them cumbersome. Introduce a simple copy based >> API that makes things considerably easier. >> >> To wit, adding a property using the raw API. >> >> struct property *prop; >> prop = kzalloc(sizeof(*prop)), GFP_KERNEL); >> prop->name = kstrdup("compatible"); >> prop->value = kstrdup("foo,bar"); >> prop->length = strlen(prop->value) + 1; >> of_changeset_add_property(ocs, np, prop); >> >> while using the helper API >> >> of_changeset_add_property_string(ocs, np, "compatible", >> "foo,bar"); >> >> Signed-off-by: Pantelis Antoniou <pantelis.antoniou@xxxxxxxxxxxx> >> [Fixed memory leak in __of_changeset_add_update_property_copy()] >> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > > You missed one fix I have in my topic/overlays branch > https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git/commit/?h=topic/overlays&id=150f95b9dec77ce371c229f7ac4d6dd8620bef4a Are you planning to try to upstream all this? If not, I'll get Frank to keep changing the overlay API to make carrying it out of tree more painful. :) Rob