Re: [PATCH v1] i2c: designware: Consider SCL GPIO optional

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > I would think all the other errors are probably something that needs
> > to be investigated.
> > eg: incorrect GPIO flags on the dt binding etc.
> 
> I agree with Phil, OTOH there are both patterns in the kernel to check
> by IS_ERR_OR_NULL vs. -ENOSYS and -ENOENT.
> 
> So, I have no strong opinion which one to use.

Okay, if you both agree that it is better to reject the driver binding
in such a case instead of printing a warning and continuing without
recovery support, then be it and I'll take this patch.

My milage varies, though, but well, nothing major.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux