Re: [PATCH 2/6] i2c: add identifier in declarations for i2c_bus_recovery

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Dec 13, 2017 at 05:23:02PM +0200, Andy Shevchenko wrote:
> On Mon, 2017-12-04 at 13:36 +0100, Wolfram Sang wrote:
> > No reason to have them undefined, so let's add them.
> > 
> 
> >  	int (*recover_bus)(struct i2c_adapter *);
> >  
> > -	int (*get_scl)(struct i2c_adapter *);
> > -	void (*set_scl)(struct i2c_adapter *, int val);
> > -	int (*get_sda)(struct i2c_adapter *);
> > +	int (*get_scl)(struct i2c_adapter *adap);
> > +	void (*set_scl)(struct i2c_adapter *adap, int val);
> > +	int (*get_sda)(struct i2c_adapter *adap);
> >  
> >  	void (*prepare_recovery)(struct i2c_adapter *);
> >  	void (*unprepare_recovery)(struct i2c_adapter *);
> 
> It seems inconsistent with the rest of the members even from this
> visible piece.

Agreed. Either overlooked, or lost during rebase. Any way, will fix!

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux