Re: [2/2] i2c: ismt: dump registers at the end of transactions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 18, 2017 at 05:01:28PM +0100, Radu Rendec wrote:
> This patch dumps general and master registers at the end of transactions
> when debugging is enabled. Previously, registers were only dumped before
> submitting new descriptors (at the beginning of transactions).
> 
> This helps debugging if some registers change as result of a failed
> transaction (e.g. bits are set in the ERRSTS general register).
> 
> Signed-off-by: Radu Rendec <radu.rendec@xxxxxxxxx>
> ---
>  drivers/i2c/busses/i2c-ismt.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/i2c/busses/i2c-ismt.c b/drivers/i2c/busses/i2c-ismt.c
> index ccce0ca..003ea53 100644
> --- a/drivers/i2c/busses/i2c-ismt.c
> +++ b/drivers/i2c/busses/i2c-ismt.c
> @@ -324,6 +324,8 @@ static int ismt_process_desc(const struct ismt_desc *desc,
>  
>  	dev_dbg(&priv->pci_dev->dev, "Processing completed descriptor\n");
>  	__ismt_desc_dump(&priv->pci_dev->dev, desc);
> +	ismt_gen_reg_dump(priv);
> +	ismt_mstr_reg_dump(priv);
>  
>  	if (desc->status & ISMT_DESC_SCS) {
>  		if (read_write == I2C_SMBUS_WRITE &&
Acked-by: Neil Horman <nhorman@xxxxxxxxxxxxx>



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux