Re: [PATCH v2 0/2] eeprom: at24: write-protect pin support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Dec 20, 2017 at 10:26 AM, Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
> AT24 EEPROMs have a write-protect pin, which - when pulled high -
> inhibits writes to the upper quadrant of memory (although it has been
> observed that on some chips it disables writing to the entire memory
> range).
>
> On some boards, this pin is connected to a GPIO and pulled high by
> default, which forces the user to manually change its state before
> writing. On linux this means that we either need to hog the line all
> the time, or set the GPIO value before writing from outside of the
> at24 driver.
>
> This series adds support for the write-protect pin split into two
> parts. The first patch extends the relevant binding document, while
> the second modifies the at24 code to pull the write-protect GPIO
> low (if present) during write operations.
>

Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

A one totally minor nit: if it possible now to have one line where
devm_gpiod_get_optional() is called?
You may ignore this nit anyway.

> v1 -> v2:
> - renamed the DT property to wp-gpios
>
> Bartosz Golaszewski (2):
>   dt-bindings: at24: new optional property - wp-gpios
>   eeprom: at24: add support for the write-protect pin
>
>  Documentation/devicetree/bindings/eeprom/at24.txt |  3 +++
>  drivers/misc/eeprom/at24.c                        | 11 +++++++++++
>  2 files changed, 14 insertions(+)
>
> --
> 2.15.1
>



-- 
With Best Regards,
Andy Shevchenko



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux