On Fri, Nov 17, 2017 at 06:31:21AM -0800, Simon Horman wrote:
> On Thu, Nov 16, 2017 at 10:27:56AM +0100, Geert Uytterhoeven wrote:
> > Hi Ulrich,
> >
> > On Wed, Nov 15, 2017 at 4:25 PM, Ulrich Hecht
> > <ulrich.hecht+renesas@xxxxxxxxx> wrote:
> > > Enables EEPROM on I2C0 on the Draak board.
> > >
> > > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@xxxxxxxxx>
> >
> > Thanks for your patch!
> >
> > > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> > > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> >
> > > @@ -67,6 +72,18 @@
> > > };
> > > };
> > >
> > > +&i2c0 {
> > > + pinctrl-0 = <&i2c0_pins>;
> > > + pinctrl-names = "default";
> > > + status = "okay";
> > > +
> > > + eeprom@50 {
> > > + compatible = "atmel,24c01";
> >
> > This is actually a ROHM Semiconductor BR24T01FVM-W, so it should be
> >
> > compatible = "rohm,br24t01", "atmel,24c01";
>
> Applied with the above change.
Sorry, I was a bit hasty there as this patch
depends on a patch earlier in the series which I have not applied.
I've dropped this patch for now and will wait a bit longer for the review
to unfold.
>
> > Please also submit a patch to add that compatible value to
> > Documentation/devicetree/bindings/eeprom/eeprom.txt.
>
> Ulrich, please follow-up on this, thanks!
>
> > With the above fixed:
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> >
> > Gr{oetje,eeting}s,
> >
> > Geert
> >
> > --
> > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
> >
> > In personal conversations with technical people, I call myself a hacker. But
> > when I'm talking to journalists I just say "programmer" or something like that.
> > -- Linus Torvalds
> >
>
