Re: [PATCH v3 1/4] i2c: Switch to using gpiod interface for gpio bus recovery

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 28/09/2017 18:58, Andy Shevchenko wrote:
On Thu, 2017-09-28 at 13:54 +0300, Jarkko Nikula wrote:
On 09/28/2017 01:44 PM, Andy Shevchenko wrote:
interface. This will allow individual driver to be updated and
tested
individual to switch to using the gpiod interface.
   	int scl_gpio;
   	int sda_gpio;
+	struct gpio_desc *scl_gpiod;
+	struct gpio_desc *sda_gpiod;

I think we even could get rid of plain integers completely.
In case some call needs it we can derive it still from the
descriptor.


I guess it's still worth to split that into multiple patches and
those
driver conversion and integer removal can be follow up patches
somewhere
in the future?

I didn't check and my memory is clean about users.
So, if there are users of those integers outside of I2C core, definitely
we need more patches / iterations.

There's a couple of drivers using those.
If my approach looks good then I can try and update those as well.

Question is does it all need to be in the one patch series?


--
Regards
Phil Reid




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux