> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License version
> + * 2 as published by the Free Software Foundation.
Here you say V2 only, in MODULE_LICENSE you say V2+.
...
> +static const struct property_entry bq24190_props[] = {
> + PROPERTY_ENTRY_STRING("extcon-name", "cht_wcove_pwrsrc"),
> + PROPERTY_ENTRY_BOOL("omit-battery-class"),
> + PROPERTY_ENTRY_BOOL("disable-reset"),
> + { }
> +};
> +
> +static int cht_wc_i2c_adap_i2c_probe(struct platform_device *pdev)
> +{
> + struct intel_soc_pmic *pmic = dev_get_drvdata(pdev->dev.parent);
> + struct cht_wc_i2c_adap *adap;
> + struct i2c_board_info board_info = {
> + .type = "bq24190",
> + .addr = 0x6b,
> + .properties = bq24190_props,
> + };
I don't know ACPI world much, but it looks to me like the wrong layer to
add this stuff? Shouldn't that be in the same place where the
i2c_adapter is instantiated? Because the place requesting the adapter
should know what is attached to it?
Attachment:
signature.asc
Description: PGP signature
