Re: [PATCH v8 3/9] i2c: core: call of_i2c_setup_smbus_alert in i2c_register_adapter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Benjamin,

On Fri, 21 Jul 2017 11:37:59 +0200, Benjamin Tissoires wrote:
> On Jul 20 2017 or thereabouts, Phil Reid wrote:
> > On 20/07/2017 02:30, kbuild test robot wrote:  
> > >   
> > 
> > I understand how this is occurring.
> > I2C=y, OF=y and I2C_PARPORT=m
> > I2C_PARPORT selects I2C_SMBUS setting it to m
> > 
> > Calling a function in i2c-smbus (module) from i2c-core (builtin) is then a problem.
> > 
> > However there doesn't seem to be a way (that I can see) to have select statement force I2C_SMBUS=y if I2C=y  
> 
> What if I2C selects I2C_SMBUS directly?

Selecting I2C_SMBUS is what device drivers are indeed supposed to do.
However doing it from i2c-core seems awkward, because i2c-smbus itself
depends on i2c-core. If they end up both built in, I guess it will be
fine. But if they are modular, I'm afraid you won't be able to load the
modules, because each of them requires the other to be loaded first for
proper symbol resolution.

-- 
Jean Delvare
SUSE L3 Support



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux