On Mon, Jun 26, 2017 at 3:44 AM, Chris Packham
<chris.packham@xxxxxxxxxxxxxxxxxxx> wrote:
On the first glance I have thought this is _the_ only patch that
doesn't make my eyes hurt.
Not a chance! Where is the commit message?
Code below though looks fine.
> @@ -107,8 +107,8 @@ static int i2c_pca_pf_waitforcompletion(void *pd)
> static void i2c_pca_pf_dummyreset(void *pd)
> {
> struct i2c_pca_pf_data *i2c = pd;
> - printk(KERN_WARNING "%s: No reset-pin found. Chip may get stuck!\n",
> - i2c->adap.name);
> +
> + dev_warn(&i2c->adap.dev, "No reset-pin found. Chip may get stuck!\n");
> }
>
> static void i2c_pca_pf_resetchip(void *pd)
> @@ -236,7 +236,7 @@ static int i2c_pca_pf_probe(struct platform_device *pdev)
>
> platform_set_drvdata(pdev, i2c);
>
> - printk(KERN_INFO "%s registered.\n", i2c->adap.name);
> + dev_info(&pdev->dev, "registered.\n");
>
> return 0;
> }
> --
> 2.13.0
>
--
With Best Regards,
Andy Shevchenko
